Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Leave dynamic dispatch in FaktoryCommand's issue fixing clippy's warnings #38

Closed
wants to merge 1 commit into from
Closed

Leave dynamic dispatch in FaktoryCommand's issue fixing clippy's warnings #38

wants to merge 1 commit into from

Conversation

rustworthy
Copy link
Collaborator

@rustworthy rustworthy commented Dec 25, 2023 •
edited
Loading

Alternative to PR

This change is Reviewable

@codecov Codecov
Copy link

codecov bot commented Dec 25, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (b63eadf) 70.0% compared to head (2bc3271) 69.9%.
Report is 2 commits behind head on main.

Additional details and impacted files
Files Coverage Δ
src/proto/single/mod.rs 86.7% <100.0%> (ø)
src/proto/single/cmd.rs 96.3% <85.7%> (-0.1%) ⬇️

... and 2 files with indirect coverage changes

@rustworthy rustworthy mentioned this pull request Dec 25, 2023
Merged
@rustworthy rustworthy changed the title [WIP] Leave dynamic dispatch in FaktoryCommand's issue fixing clippy's warnings Leave dynamic dispatch in FaktoryCommand's issue fixing clippy's warnings Dec 25, 2023
@jonhoo
Copy link
Owner

jonhoo commented Jan 3, 2024

Took #39 👍

@jonhoo jonhoo closed this Jan 3, 2024
@rustworthy rustworthy deleted the chore/clippy-warnings branch January 4, 2024 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rustworthy @jonhoo